GEPRC_F722_AIO add target with UART3 instead of i2c #10310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmosca
reviewed
Aug 21, 2024
| @@ -53,6 +57,8 @@ | |||
|
|
|||
| // *************** I2C/Baro/Mag ********************* | |||
| #define USE_I2C | |||
There was a problem hiding this comment.
USE_I2C should probably be inside the ifdef bellow as well
There was a problem hiding this comment.
USE_I2C should probably be inside the ifdef bellow as well
Done.
It looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The board shares the same pins between UART3 and external i2c.
This PR allows the user to choose UART3 rather than external i2c.
This is based on the co mment from @YI-BOYANG on #10233
@YI-BOYANG does this look okay to you?